Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(typescript-resolvers): make enum resolvers work with external enums and internal values mapping #4205

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

dotansimha
Copy link
Owner

@dotansimha dotansimha commented Jun 10, 2020

Related: #3985

TODO:

  • Make sure we have tests for all use cases
  • Fix flow-resolvers
  • Make sure we cover all options of enumValues
  • Make sure it's compatible with mappers as well.
  • Fix for enumValues with explicit mapped fields (to enforce the specific values)
  • Add docs

Sorry, something went wrong.

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 10, 2020

The latest changes of this PR are available as alpha in npm: 1.15.3-alpha-5fb6a6a9.0

Quickly update your package.json by running:

npx match-version @graphql-codegen 1.15.3-alpha-5fb6a6a9.0

@dotansimha dotansimha marked this pull request as draft June 10, 2020 16:56
@dotansimha dotansimha requested a review from kamilkisiela June 10, 2020 16:56
@dotansimha dotansimha changed the title Making enum resolvers work feature(typescript-resolvers): make enum resolvers work with external enums and internal values mapping Jun 10, 2020
@dotansimha dotansimha marked this pull request as ready for review June 11, 2020 07:01
@dotansimha dotansimha merged commit f9c4d1c into master Jun 11, 2020
@dotansimha dotansimha deleted the resolvers-package-fixes branch June 11, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[typescript-resolvers] Better support for enum, mappers and internal values
3 participants