fix: change titleCase to pascalCase #2433
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
commented
Aug 23, 2019
| @@ -174,7 +174,7 @@ export class ReactApolloVisitor extends ClientSideBaseVisitor<ReactApolloRawPlug | |||
|
|
|||
| if (operationType === 'Query') { | |||
| const lazyOperationName: string = this.convertName(node.name.value, { | |||
| suffix: titleCase('LazyQuery'), | |||
| suffix: pascalCase('LazyQuery'), | |||
There was a problem hiding this comment.
I've kept this call here even though it's an expensive no-op to aid future copy-pasting. We could simplify this to:
Suggested change
| suffix: pascalCase('LazyQuery'), | |
| suffix: 'LazyQuery', |
|
Thanks for the nice fix, I was suffering this issue. |
ardatan
approved these changes
Aug 27, 2019
|
Thank you @benjie ! This is awesome. Any chance you can rebase and resolve conflicts? |
|
@dotansimha I’m away so I’ve attempted to do so from my phone; hopefully it’s all good but if not let me know and I can fix it from my computer next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396
titleCaseadds spaces at word boundaries; we do not want spaces in any of these places. This PR changestitleCaseusage topascalCaseto match the rest of the codebase.(Most of the uses of
titleCasecurrently work because they run against a single word (operationType) so no spaces are added; however keeping these opens the door to copy/paste errors so I think it's safer to eradicatetitleCase.)