Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-folder param to near-operation-file #2429

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

fforres
Copy link
Contributor

@fforres fforres commented Aug 22, 2019

I was wondering if there was a way we could create a sub-folder to save all our code-generated files instead of just appending them into the same folder, and I stumbled across #2287 issue / comment by @RIP21.

And since I had a bit of free time, I made a PR for it

  • A added a new optional option folder to the near-operation-file config
  • It sets a relative sub-folder where to save the files generated by the code-generator.

Once thing I didn't know how to (Or what does the project use them for) is the files under dev-test.
I did modified the ./dev-test/githunt option under dev-test/codegen.yml option to test the plugin changes there... Buts I guess there must be a better option?

Anyways, Looking forward to comments / inputs on the PR.

All the best!

cc @dotansimha

@dotansimha
Copy link
Owner

That's AWESOME!!! Thank you so much @fforres ! Looks great.

@dotansimha dotansimha merged commit 20aa880 into dotansimha:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants