Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-react-apollo] Fix external mode to avoid importing operations in files that don't have operations #2392

Merged

Conversation

eddeee888
Copy link
Collaborator

Currently, in external mode, we are importing nodes even for files without operations i.e. files with just fragments. This behaviour can be seen here: https://codesandbox.io/s/gcg-16-experiments-c8l15 in src/webpack/GetProject_Id.fragment.generated.tsx

This PR adds a check to make sure we don't import operations unnecessarily

@dotansimha
Copy link
Owner

Thanks @eddeee888 !

@dotansimha dotansimha merged commit 42ab136 into dotansimha:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants