fix issues with init command and missing versions (#4809)

Author: dotansimha

.changeset/plenty-stingrays-run.md

@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': patch
+---
+
+fix issues with init command and missing versions

packages/graphql-codegen-cli/package.json

@@ -40,6 +40,7 @@
   },
   "homepage": "https://github.com/dotansimha/graphql-code-generator#readme",
   "dependencies": {
+    "latest-version": "5.1.0",
     "@graphql-codegen/core": "1.17.8",
     "@graphql-codegen/plugin-helpers": "^1.17.8",
     "@graphql-tools/apollo-engine-loader": "^6",

packages/graphql-codegen-cli/src/init/helpers.ts

@@ -4,6 +4,7 @@ import { writeFileSync, readFileSync } from 'fs';
 import { Types } from '@graphql-codegen/plugin-helpers';
 import detectIndent from 'detect-indent';
 import { Answers } from './types';
+import getLatestVersion from 'latest-version';
 
 // Parses config and writes it to a file
 export async function writeConfig(answers: Answers, config: Types.Config) {
@@ -44,30 +45,17 @@ export async function writePackage(answers: Answers, configLocation: string) {
     pkg.devDependencies = {};
   }
 
-  // read codegen's version
-  let version: string;
-
-  const dynamicImport = (m: string) => import(m).then(m => ('default' in m ? m.default : m));
-  try {
-    // Works in tests
-    const packageJson = await dynamicImport('../../package.json');
-    version = packageJson.version;
-  } catch (e) {
-    // Works in production (package dist is flat, everything is in the same folder)
-    const packageJson = await dynamicImport('./package.json');
-    version = packageJson.version;
-  }
-
-  answers.plugins.forEach(plugin => {
-    pkg.devDependencies[plugin.package] = version;
-  });
+  await Promise.all(
+    answers.plugins.map(async plugin => {
+      pkg.devDependencies[plugin.package] = await getLatestVersion(plugin.package);
+    })
+  );
 
   if (answers.introspection) {
-    pkg.devDependencies['@graphql-codegen/introspection'] = version;
+    pkg.devDependencies['@graphql-codegen/introspection'] = await getLatestVersion('@graphql-codegen/introspection');
   }
 
-  // If cli haven't installed yet
-  pkg.devDependencies['@graphql-codegen/cli'] = version;
+  pkg.devDependencies['@graphql-codegen/cli'] = await getLatestVersion('@graphql-codegen/cli');
 
   writeFileSync(pkgPath, JSON.stringify(pkg, null, indent));
 }

packages/graphql-codegen-cli/src/init/index.ts

@@ -40,6 +40,8 @@ export async function init() {
   // config file
   const { relativePath } = await writeConfig(answers, config);
 
+  log(`Fetching latest versions of selected plugins...`);
+
   // write package.json
   await writePackage(answers, relativePath);
 

packages/graphql-codegen-cli/tests/init.spec.ts

@@ -1,3 +1,8 @@
+/* eslint-disable import/first */
+jest.mock('latest-version', () => {
+  return () => Promise.resolve('1.0.0');
+});
+
 import bddStdin from 'bdd-stdin';
 import { resolve } from 'path';
 import { init } from '../src/init';
@@ -294,7 +299,7 @@ describe('init', () => {
     expect(config.schema).toEqual(defaults.schema);
     expect(config.documents).toEqual(defaults.documents);
     expect(config.generates[defaults.output]).toBeDefined();
-    expect(logSpy.mock.calls[1][0]).toContain(`Config file generated at ${bold(defaults.config)}`);
+    expect(logSpy.mock.calls[2][0]).toContain(`Config file generated at ${bold(defaults.config)}`);
   });
 
   it('should have few default values', async () => {
@@ -334,7 +339,7 @@ describe('init', () => {
     expect(config.schema).toEqual(options.schema);
     expect(config.documents).toEqual(options.documents);
     expect(config.generates[options.output]).toBeDefined();
-    expect(logSpy.mock.calls[1][0]).toContain(`Config file generated at ${bold(options.config)}`);
+    expect(logSpy.mock.calls[2][0]).toContain(`Config file generated at ${bold(options.config)}`);
   });
 
   it('custom setup', async () => {
@@ -392,7 +397,7 @@ describe('init', () => {
 
     // logs
     const welcomeMsg = logSpy.mock.calls[0][0];
-    const doneMsg = logSpy.mock.calls[1][0];
+    const doneMsg = logSpy.mock.calls[2][0];
 
     expect(welcomeMsg).toContain(`Welcome to ${bold('GraphQL Code Generator')}`);
     expect(doneMsg).toContain(`Config file generated at ${bold('codegen.yml')}`);

yarn.lock

@@ -11051,20 +11051,20 @@ last-call-webpack-plugin@^3.0.0:
     lodash "^4.17.5"
     webpack-sources "^1.1.0"
 
+latest-version@5.1.0, latest-version@^5.0.0:
+  version "5.1.0"
+  resolved "https://registry.yarnpkg.com/latest-version/-/latest-version-5.1.0.tgz#119dfe908fe38d15dfa43ecd13fa12ec8832face"
+  integrity sha512-weT+r0kTkRQdCdYCNtkMwWXQTMEswKrFBkm4ckQOMVhhqhIMI1UT2hMj+1iigIhgSZm5gTmrRXBNoGUgaTY1xA==
+  dependencies:
+    package-json "^6.3.0"
+
 latest-version@^3.0.0:
   version "3.1.0"
   resolved "https://registry.npmjs.org/latest-version/-/latest-version-3.1.0.tgz#a205383fea322b33b5ae3b18abee0dc2f356ee15"
   integrity sha1-ogU4P+oyKzO1rjsYq+4NwvNW7hU=
   dependencies:
     package-json "^4.0.0"
 
-latest-version@^5.0.0:
-  version "5.1.0"
-  resolved "https://registry.yarnpkg.com/latest-version/-/latest-version-5.1.0.tgz#119dfe908fe38d15dfa43ecd13fa12ec8832face"
-  integrity sha512-weT+r0kTkRQdCdYCNtkMwWXQTMEswKrFBkm4ckQOMVhhqhIMI1UT2hMj+1iigIhgSZm5gTmrRXBNoGUgaTY1xA==
-  dependencies:
-    package-json "^6.3.0"
-
 lazy-cache@^0.2.3:
   version "0.2.7"
   resolved "https://registry.npmjs.org/lazy-cache/-/lazy-cache-0.2.7.tgz#7feddf2dcb6edb77d11ef1d117ab5ffdf0ab1b65"