Fixes mistaken MODULE_NOT_FOUND error for missing dependency (#5255)

lucasconstantino · web-flow · commit 9ebf1877b65e · 2020-12-17T17:58:25.000+02:00
diff --git a/.changeset/loud-clouds-lick.md b/.changeset/loud-clouds-lick.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': patch
+---
+
+Fix wrong MODULE_NOT_FOUND for missing dependencies
diff --git a/packages/graphql-codegen-cli/src/plugins.ts b/packages/graphql-codegen-cli/src/plugins.ts
@@ -22,7 +22,7 @@ export async function getPluginByName(
     try {
       return await pluginLoader(moduleName);
     } catch (err) {
-      if (err.code !== 'MODULE_NOT_FOUND') {
+      if (err.code !== 'MODULE_NOT_FOUND' || !err.message.includes(moduleName)) {
         throw new DetailedError(
           `Unable to load template plugin matching ${name}`,
           `
diff --git a/packages/graphql-codegen-cli/src/presets.ts b/packages/graphql-codegen-cli/src/presets.ts
@@ -18,7 +18,7 @@ export async function getPresetByName(
 
       return loaded as Types.OutputPreset;
     } catch (err) {
-      if (err.code !== 'MODULE_NOT_FOUND') {
+      if (err.code !== 'MODULE_NOT_FOUND' || !err.message.includes(moduleName)) {
         throw new DetailedError(
           `Unable to load preset matching ${name}`,
           `

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export async function getPluginByName(`
`22`	`22`	`try {`
`23`	`23`	`return await pluginLoader(moduleName);`
`24`	`24`	`} catch (err) {`
`25`		`- if (err.code !== 'MODULE_NOT_FOUND') {`
	`25`	`+ if (err.code !== 'MODULE_NOT_FOUND' \|\| !err.message.includes(moduleName)) {`
`26`	`26`	`throw new DetailedError(`
`27`	`27`	`Unable to load template plugin matching ${name}`,
`28`	`28`	`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export async function getPresetByName(`
`18`	`18`
`19`	`19`	`return loaded as Types.OutputPreset;`
`20`	`20`	`} catch (err) {`
`21`		`- if (err.code !== 'MODULE_NOT_FOUND') {`
	`21`	`+ if (err.code !== 'MODULE_NOT_FOUND' \|\| !err.message.includes(moduleName)) {`
`22`	`22`	`throw new DetailedError(`
`23`	`23`	`Unable to load preset matching ${name}`,
`24`	`24`	`