Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config parameter for predicate quantifier #224

Merged
merged 1 commit into from Mar 2, 2024

Conversation

petermetz
Copy link
Contributor

Setting the new 'predicate-quantifier' configuration parameter to 'every'
makes it so that all the patterns have to match a file for it to be
considered changed.

This can be leveraged to ensure that you only build & test software changes
that have real impact on the behavior of the code, e.g. you can set up your
build to run when Typescript/Rust/etc. files are changed but markdown
changes in the diff will be ignored and you consume less resources to build.

The default behavior does not change by the introduction of this feature
so upgrading can be done safely knowing that existing workflows will not
break.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Setting the new 'predicate-quantifier' configuration parameter to 'every'
makes it so that all the patterns have to match a file for it to be
considered changed.

This can be leveraged to ensure that you only build & test software changes
that have real impact on the behavior of the code, e.g. you can set up your
build to run when Typescript/Rust/etc. files are changed but markdown
changes in the diff will be ignored and you consume less resources to build.

The default behavior does not change by the introduction of this feature
so upgrading can be done safely knowing that existing workflows will not
break.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link
Contributor Author

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @outSH

@PetersonBenhameCEO
Copy link

ok

@petermetz
Copy link
Contributor Author

@PetersonBenhameCEO Thank you!

@dorny
Copy link
Owner

dorny commented Mar 2, 2024

@petermetz Thanks for the PR. It's very well-prepared. I will merge it now and release a new version.

@dorny dorny merged commit cf89abd into dorny:master Mar 2, 2024
7 checks passed
@petermetz petermetz deleted the feat-filter-predicate-quantifier branch March 2, 2024 21:30
@petermetz
Copy link
Contributor Author

@petermetz Thanks for the PR. It's very well-prepared. I will merge it now and release a new version.

@dorny Yay, thank you very much! Looking forward to using the new release in our CI! 🎉

@dorny
Copy link
Owner

dorny commented Mar 2, 2024

Released as v3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants