Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Action to use node 16 instead of node 12 #156

Closed
ericcornelissen opened this issue Sep 26, 2022 · 2 comments
Closed

Upgrade Action to use node 16 instead of node 12 #156

ericcornelissen opened this issue Sep 26, 2022 · 2 comments

Comments

@ericcornelissen
Copy link

ericcornelissen commented Sep 26, 2022

Following the recent blog post "GitHub Actions: All Actions will begin running on Node16 instead of Node12" by GitHub, I noticed this action is still running on node12:

paths-filter/action.yml

Lines 50 to 52 in 8c7f485

runs:
using: 'node12'
main: 'dist/index.js'

It should be fairly easy to change this by replacing using: node12 with using: node16 - I wouldn't expect anything in this Action's source code to break as a result of that.

One thing to note, by and large I've seen other Actions use a major version bump when releasing this change. The motivation being that older GitHub Actions runners may not support node16. See for example the "What's new" section of actions/checkout.


I noticed #151 includes this change. However, it's scope is quite broad which might be holding it back. Hence, I created this ticket to bring extra attention to this particular aspect of that PR.

@dorny
Copy link
Owner

dorny commented Oct 11, 2022

Thanks for reporting the issue. The action was updated to use node16 in #161

@dorny dorny closed this as completed Oct 11, 2022
@Anil1415
Copy link

I am getting an error that Node 12 deprecated while deploying through Azure github actions.
I searched on internet and found out to update to Node 16
can anybody help me out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants