Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort memberof #1452

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Sort memberof #1452

merged 6 commits into from
Jan 30, 2024

Conversation

mmomtchev
Copy link
Contributor

Support sorting by memberof - needed because documentation will start by sorting the whole collection of comment blocks and then it will create sections when encountering the first member of each section. Thus, without memberof sort, sections will be sorted by the position of their first member.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@franklygeorgy
Copy link
Contributor

If this was merged it would be appreciated.

@tmcw tmcw merged commit e030a3f into documentationjs:master Jan 30, 2024
@mmomtchev mmomtchev deleted the sort-memberof branch January 30, 2024 20:44
@mmomtchev
Copy link
Contributor Author

It has been more than 2 years since I forked this project

@tmcw
Copy link
Member

tmcw commented Jan 30, 2024

Life sometimes gets in the way of merging PRs 😆 . Sorry for the delay and thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants