Analyze Middleware directory #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use it in one of our classes, that we should be able to statically analyze or test.
ostrolucky
reviewed
Mar 14, 2024
psalm.xml.dist
Outdated
Comment on lines
41
to
52
| <InternalClass> | ||
| <errorLevel type="suppress"> | ||
| <!-- Random package should not call this class from the Doctrine bridge, but we are in the Doctrine bundle here --> | ||
| <referencedClass name="Symfony\Bridge\Doctrine\Middleware\Debug\Driver"/> | ||
| </errorLevel> | ||
| </InternalClass> | ||
| <InternalMethod> | ||
| <errorLevel type="suppress"> | ||
| <!-- Random package should not call this method from the Doctrine bridge, but we are in the Doctrine bundle here --> | ||
| <referencedMethod name="Symfony\Bridge\Doctrine\Middleware\Debug\Driver::__construct"/> | ||
| </errorLevel> | ||
| </InternalMethod> |
There was a problem hiding this comment.
do these not work as @psalm-suppress?
There was a problem hiding this comment.
We do have a lot psalm-suppres in the code and we do have a lot suppress in the psalm config. Is there a pattern in DoctrineBundle when to use one or the other?
There was a problem hiding this comment.
Pattern is that we put stuff into config that does not work with inline suppress. There are plenty of such cases when psalm-suppress doesn't have an effect but putting it to config does.
There was a problem hiding this comment.
do these not work as
@psalm-suppress?
I'll try, it's just that I forgot that we were doing things like this in that repository.
It seems to have been forgotten.
greg0ire
force-pushed
the
analyze-middleware
branch
from
a6aa83d
to
d05c094
Compare
ostrolucky
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on #1767