Provide outputs as env vars #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
jedevc
reviewed
Jan 13, 2023
Comment on lines
+308
to
+315
| So it can be used with our [Docker Build Push action](https://github.com/docker/build-push-action/): | ||
|
|
||
| ```yaml | ||
| - uses: docker/build-push-action@v3 | ||
| with: | ||
| build-args: | | ||
| DOCKER_METADATA_OUTPUT_JSON | ||
| ``` |
There was a problem hiding this comment.
I can't find docs in build-push-action that describe the syntax for this - we should probably add that on merging this.
There was a problem hiding this comment.
Yes it's a core implementation where you can use --build-arg flag without a value: https://docs.docker.com/engine/reference/commandline/build/#-set-build-time-variables---build-arg
You may also use the
--build-argflag without a value, in which case the value
from the local environment will be propagated into the Docker container being
built:$ export HTTP_PROXY=http://10.20.30.2:1234 $ docker build --build-arg HTTP_PROXY .
jedevc
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/build-push-action#736 (comment)
cc @ruslandoga