Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more details in errNotManifestOrIndex #47735

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

cpuguy83
Copy link
Member

This error is returned when attempting to walk a descriptor that should be an index or a manifest.
Without this the error is not very helpful sicne there's no way to tell what triggered it.

This error is returned when attempting to walk a descriptor that
*should* be an index or a manifest.
Without this the error is not very helpful sicne there's no way to tell
what triggered it.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were too fast, was going to comment on that extra “:” :)

@cpuguy83
Copy link
Member Author

You were too fast, was going to comment on that extra “:” :)

No one was supposed to see that!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neersighted neersighted added this to the 27.0.0 milestone Apr 20, 2024
@neersighted neersighted added containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Apr 20, 2024
@neersighted neersighted merged commit 801fd16 into moby:master Apr 20, 2024
134 checks passed
@vvoland vvoland modified the milestones: 27.0.0, 26.1.0 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/4-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants