Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid nil dereference on image history Created value #47734

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

krissetto
Copy link
Contributor

@krissetto krissetto commented Apr 19, 2024

- What I did
Fix nil dereference of Created in image history.

closes #47729

- How I did it
checked for nil ;)

- How to verify it
repo from this issue no longer causes issues

- Description for the changelog

Fix a nil dereference when getting image history for images having layers without the `Created` value set

- A picture of a cute animal (not mandatory but encouraged)

Issue was caused by the changes here moby#45504
First released in v25.0.0-beta.1

Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
@krissetto krissetto force-pushed the image-history-timestamp-dereference branch from 1c407b3 to ab570ab Compare April 19, 2024 10:44
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could include it in changelog, since it fixes a panic which is visible to the user

Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit ee8b788 into moby:master Apr 19, 2024
137 of 138 checks passed
@krissetto krissetto deleted the image-history-timestamp-dereference branch April 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nil dereference when created timestamp is missing in image history
3 participants