Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: document changed behavior of the Aliases field in v1.45 #47599

Merged
merged 1 commit into from Mar 20, 2024

Conversation

neersighted
Copy link
Member

- What I did

Address my concerns with the deprecations in docker/cli#4949 (review)

Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Mar 20, 2024

@vvoland I think this one is fine to merge without waiting all of CI to finish (at your discretion)

@neersighted neersighted merged commit 8b79278 into moby:master Mar 20, 2024
103 of 104 checks passed
@neersighted neersighted deleted the short_id_aliases_removal branch March 20, 2024 14:33
Copy link
Member

@akerouanton akerouanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants