c8d/list: Fix shared size calculation #47597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
area/images
kind/bugfix
After a535a65 the size reported by the image list was changed to include all platforms of that image. This made the "shared size" calculation consider all diff ids of all the platforms available in the image which caused "snapshot not found" errors when multiple images were sharing the same layer which wasn't unpacked. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The `identity.ChainIDs` call was accidentally removed in b37ced2. This broke the shared size calculation for images with more than one layer that were sharing the same compressed layer. This was could be reproduced with: ``` $ docker pull docker.io/docker/desktop-kubernetes-coredns:v1.11.1 $ docker pull docker.io/docker/desktop-kubernetes-etcd:3.5.10-0 $ docker system df ``` Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
c8d-list-fix-shared-size
branch
from
26efc64
to
ad8a5a5
Compare
vvoland
changed the title
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
c8d-list-fix-shared-size
branch
from
72cab54
to
3312b82
Compare
neersighted
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix diffIDs being outputted instead of chainIDs
The
identity.ChainIDscall was accidentally removed in b37ced2.This broke the shared size calculation for images with more than one layer that were sharing the same compressed layer.
Handle unpacked layers when calculating shared size
After a535a65 the size reported by the image list was changed to include all platforms of that image.
This made the "shared size" calculation consider all diff ids of all the platforms available in the image which caused "snapshot not found" errors when multiple images were sharing the same layer which wasn't
unpacked.
Found by @milas
- What I did
- How I did it
- How to verify it
This was could be reproduced with:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)