Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[25.0 backport] hack/make.ps1: Fix go list pattern #47265

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[25.0 backport] hack/make.ps1: Fix go list pattern #47265

merged 1 commit into from
Jan 31, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Jan 31, 2024 •
edited by thaJeztah

The double quotes inside a single quoted string don't need to be escaped.
Looks like different Powershell versions are treating this differently and it started failing unexpectedly without any changes on our side.

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com
(cherry picked from commit ecb217c)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland
hack/make.ps1: Fix go list pattern
1b47bfa 
The double quotes inside a single quoted string don't need to be
escaped.
Looks like different Powershell versions are treating this differently
and it started failing unexpectedly without any changes on our side.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit ecb217c)
@vvoland vvoland added this to the 25.0.2 milestone Jan 31, 2024
@vvoland vvoland self-assigned this Jan 31, 2024
thaJeztah
thaJeztah approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Failure is unrelated; known flaky;

=== Failed
=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.32s)
    daemon_test.go:581: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.32s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (17.19s)
    --- FAIL: TestLiveRestore/volume_references (17.19s)

=== FAIL: amd64.integration.daemon TestLiveRestore (0.00s

@vvoland vvoland marked this pull request as ready for review January 31, 2024 19:58
@vvoland vvoland requested a review from tianon as a code owner January 31, 2024 19:58
@thaJeztah
Copy link
Member

Windows is happy; bringing this one in

@thaJeztah thaJeztah merged commit 667bc3f into moby:25.0 Jan 31, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@vvoland vvoland

Labels
area/testing kind/bugfix PR's that fix bugs platform/windows status/2-code-review
Projects
None yet
Milestone
25.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vvoland @thaJeztah