Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0 backport] integration: Add TestImageInspectEmptyTagsAndDigests #45612

Merged
merged 4 commits into from May 25, 2023

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented May 25, 2023

Related to:

- What I did
Implemented integration test for regression described in #45556

- How I did it

  • Create an empty image without any tag. Similiar to emptyfs, except used a newer archive format and different image config format).
  • Check the parsed and raw output of ImageInspectWithRaw called against that image

- How to verify it
make TEST_FILTER=TestImageInspectEmptyTagsAndDigests test-integration (or watch CI)
make TEST_INTEGRATION_USE_SNAPSHOTTER=1 DOCKER_GRAPHDRIVER=overlayfs test-integration

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
image

thaJeztah and others added 4 commits May 25, 2023 09:48
To allow skipping integration tests that don't apply to the
containerd snapshotter.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 4373547)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 3a31f81)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit a93aadc)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 6506579)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah changed the title [backport 24.0] integration: Add TestImageInspectEmptyTagsAndDigests [24.0 backport] integration: Add TestImageInspectEmptyTagsAndDigests May 25, 2023
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 9d8acb7 into moby:24.0 May 25, 2023
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants