vendor: github.com/docker/docker v28.0.2-dev (bea4de25004d) #5929
+370
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5929 +/- ##
==========================================
+ Coverage 59.28% 59.43% +0.15%
==========================================
Files 358 358
Lines 29830 29769 -61
==========================================
+ Hits 17685 17694 +9
+ Misses 11173 11107 -66
+ Partials 972 968 -4 🚀 New features to boost your workflow:
|
|
@vvoland it's probably better to remove the "cherry-picked from" line from the commit message, because if this PR gets merged, the other one won't be (so that commit will not be related to anything); 
|
|
Right! I'll change this when updating this PR later to the latest moby (after merging the remaining PRs) |
Starting with [moby@b633c4c], the registry package handles this internally and there's no longer a need to set the path manually for rootlessKit [moby@b633c4c]: moby/moby@b633c4c Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
full diff: moby/moby@v28.0.1...bea4de2 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
changed the title
This validation is now handled by the API-client since [moby@5d6b566], so no longer needed to be done in the cli. This function was only used internally and has no external consumers, so removing it without deprecating first. [moby@5d6b566]: moby/moby@5d6b566 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Since [moby@c2c3d59], [registry.ParseRepositoryInfo] now always returns a nil error, so we can remove the error handling. [registry.ParseRepositoryInfo]: https://github.com/moby/moby/blob/5f0d6731eb015c8e46b2ae9bb1803d005f2513be/registry/config.go#L414-L443 [moby@c2c3d59]: moby/moby@c2c3d59 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: moby/moby@v28.0.1...bea4de2
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com