Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed descriptions for --ulimit options in docker run documentation #5870

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

thaJeztah
Copy link
Member


- What I did
Add available options for --ulimit flag in docker run command
- How I did it
According to units.go file in docker/go-units repository, i updated the documentation

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

…ation

Signed-off-by: MHM0098 <mhm98035@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Quick rebase and small formatting changes of #5870 - I think these changes look good (but the formatting was a bit off); didn't want to push to the other PR's branch, as it was opened from their master branch (which always gives me the creeps force-pushing to 😂)

cc @vvoland @Benehiko

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (77a8a8c) to head (d75f8d8).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5870      +/-   ##
==========================================
- Coverage   59.30%   59.27%   -0.03%     
==========================================
  Files         353      353              
  Lines       29694    29694              
==========================================
- Hits        17609    17601       -8     
- Misses      11104    11113       +9     
+ Partials      981      980       -1     

@Benehiko
Copy link
Member

@thaJeztah Could add @MHM98 as a co-author

Co-authored-by-by: MHM0098 <mhm98035@gmail.com>

@thaJeztah
Copy link
Member Author

I think in this case that's not needed, as I took the original commit, which still has them as author of the commit (so Git / GitHub would show it as Author: @MHM98 and Committer: @thaJeztah);

git show
commit d75f8d83d31b15c548fe82aa05345f33df72de9f (HEAD -> carry_5855, origin/carry_5855)
Author: MHM0098 <mhm98035@gmail.com>
Date:   Fri Feb 21 17:10:35 2025 +0330

    Add detailed descriptions for --ulimit options in docker run documentation

    Signed-off-by: MHM0098 <mhm98035@gmail.com>
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants