-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/dockerfiles: Update CMD instruction in 'Dockerfile.dev' to use exec form #5742
fix/dockerfiles: Update CMD instruction in 'Dockerfile.dev' to use exec form #5742
Conversation
dockerfiles/Dockerfile.dev
Outdated
CMD bash | ||
CMD ["bash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be /bin/bash
;
docker run -it --rm alpine
ask add --no-cache bash
command -v bash
/bin/bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed it. Thank you.
40ce68a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like the second commit is missing a DCO sign-off, which makes CI fail
could you squash both commits (we prefer not to keep history for fix-ups like this), and amend the commit message so that it has a DCO sign-off?
Let me know if you need help doing so!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5742 +/- ##
==========================================
- Coverage 59.51% 59.48% -0.04%
==========================================
Files 346 346
Lines 29376 29367 -9
==========================================
- Hits 17483 17468 -15
- Misses 10923 10926 +3
- Partials 970 973 +3 |
…xec form instead of shell form * https://docs.docker.com/reference/build-checks/json-args-recommended/ Signed-off-by: Mert Şişmanoğlu <mert190737fb@gmail.com>
40ce68a
to
48dbdc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sorry for the delay! I saw this warning when I built the Dockerfile and thought "didn't we merge a PR for that?" then realising it was still pending 🙈
Thanks for contributing!
- What I did
I updated the CMD instruction in the
dockerfiles/Dockerfile.dev
to prevent theJSONArgsRecommended
build check warning.- How I did it
I followed the dockerdocs instructions
- How to verify it
You can run
make dev
command on the master branch, when the build finished successfully it shows a yellowish "JSONArgsRecommended" warning.Once you switch to the
fix-dockerfile-exec-form
branch, and re-runmake dev
you will not see anyJSONArgsRecommended
warning.The expected output:

- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)