Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: pass command execution error to plugins #5033

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

laurazard
Copy link
Member

- What I did

Added a field to HookPluginData to hold the error message (if applicable) that resulted from the execution for which the hook is being invoked.

This is only available for CLI command executions.

- How to verify it

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland added this to the 26.1.0 milestone Apr 22, 2024
@vvoland vvoland merged commit e397e50 into docker:master Apr 22, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants