Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26.0 backport] cli-bin/windows: Add .exe extension #5006

Merged
merged 1 commit into from Apr 11, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Apr 11, 2024

Before this commit, the CLI binary in dockereng/cli-bin image was named docker regardless of platform.

Change the binary name to docker.exe in Windows images.

Before this commit, the CLI binary in `dockereng/cli-bin` image was
named `docker` regardless of platform.

Change the binary name to `docker.exe` in Windows images.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 718203d)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krissetto krissetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit 3cf84fb into docker:26.0 Apr 11, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants