scripts/vendor: remove -compat=1.19 #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally added this -compat to keep a consistent format of the vendor.mod files for cases where there were differences between go versions. I don't think we really need this anymore, so let's remove. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4945 +/- ##
=======================================
Coverage 61.43% 61.44%
=======================================
Files 289 289
Lines 20241 20241
=======================================
+ Hits 12435 12437 +2
+ Misses 6904 6903 -1
+ Partials 902 901 -1 |
vvoland
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally added this -compat to keep a consistent format of the vendor.mod files for cases where there were differences between go versions.
I don't think we really need this anymore, so let's remove.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)