vendor: github.com/docker/docker 70e46f2c7c2d (v26.0.0-rc3-dev) #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Mar 16, 2024
vendor.mod
Outdated
Comment on lines
7
to
9
| go 1.21 | ||
|
|
||
| toolchain go1.21.8 |
There was a problem hiding this comment.
Hmm.. looks like the containerd update forces go 1.21 to be set here, and also inserts a toolchain. Not sure if we want/need that? Looks like it's possible to manually remove it (and won't add it back)
no changes in vendored files, but now requires go1.21 full diff: containerd/containerd@v1.7.13...v1.7.14 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…f v1.5.4 full diffs: - protocolbuffers/protobuf-go@v1.31.0...v1.33.0 - golang/protobuf@v1.5.3...v1.5.4 From the Go security announcement list; > Version v1.33.0 of the google.golang.org/protobuf module fixes a bug in > the google.golang.org/protobuf/encoding/protojson package which could cause > the Unmarshal function to enter an infinite loop when handling some invalid > inputs. > > This condition could only occur when unmarshaling into a message which contains > a google.protobuf.Any value, or when the UnmarshalOptions.UnmarshalUnknown > option is set. Unmarshal now correctly returns an error when handling these > inputs. > > This is CVE-2024-24786. In a follow-up post; > A small correction: This vulnerability applies when the UnmarshalOptions.DiscardUnknown > option is set (as well as when unmarshaling into any message which contains a > google.protobuf.Any). There is no UnmarshalUnknown option. > > In addition, version 1.33.0 of google.golang.org/protobuf inadvertently > introduced an incompatibility with the older github.com/golang/protobuf > module. (golang/protobuf#1596) Users of the older > module should update to github.com/golang/protobuf@v1.5.4. govulncheck results in our code shows that this does not affect the CLI: govulncheck ./... Scanning your code and 448 packages across 72 dependent modules for known vulnerabilities... === Symbol Results === No vulnerabilities found. Your code is affected by 0 vulnerabilities. This scan also found 1 vulnerability in packages you import and 0 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_engine
branch
2 times, most recently
from
e008c9c
to
ffa2659
Compare
full diff: moby/moby@v26.0.0-rc2...70e46f2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_engine
branch
from
ffa2659
to
38c3ff6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4944 +/- ##
=======================================
Coverage 61.43% 61.44%
=======================================
Files 289 289
Lines 20241 20241
=======================================
+ Hits 12435 12437 +2
+ Misses 6904 6903 -1
+ Partials 902 901 -1 |
|
Hm.. CodeQL looks to be having a hard time; |
|
Previous run on #4929 completed in 2 minutes, and shows this instead (looks to be a slightly older version; |
|
That one also used a different version of go; vs |
|
Looks like it somewhat completed after an hour and a half 😂 
But not sure if it did the right thing (logs attached); It's doing a lot of weird things, such as creating new modules for each and every package, including vendored dependencies 🙈 👇 raw logs below |
vvoland
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/containerd/containerd v1.7.14
no changes in vendored files, but now requires go1.21
full diff: containerd/containerd@v1.7.13...v1.7.14
vendor: google.golang.org/protobuf v1.33.0, github.com/golang/protobuf v1.5.4
full diffs:
From the Go security announcement list;
In a follow-up post;
govulncheck results in our code shows that this does not affect the CLI:
vendor: github.com/docker/docker 70e46f2c7c2d (v26.0.0-rc3-dev)
full diff: moby/moby@v26.0.0-rc2...70e46f2
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)