New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distribution/distribution registry to e2e tests #812

Closed

jedevc opened this issue Feb 21, 2023 · 1 comment · Fixed by #814

Contributor

jedevc commented Feb 21, 2023

Similar to #804 and #790 (and many others), we should add tests for the distribution/distribution registry as well: https://github.com/distribution/distribution/.

WDYT @crazy-max?

Member

crazy-max commented Feb 21, 2023 •

edited

We already have this in our workflows actually like:

build-push-action/.github/workflows/ci.yml

Lines 49 to 53 in 7944f9a

    
           services: 
        
             registry: 
        
               image: registry:2 
        
               ports: 
        
                 - 5000:5000

But not in the e2e workflow. Fine to add a case in our matrix for this too 👍

This was referenced Feb 22, 2023

e2e: add distribution tests #813

Closed

e2e: add distribution tests #814

Merged

jedevc closed this as completed in #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment