Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable quotes detection for "outputs" input #1074

Merged
merged 3 commits into from Mar 7, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 6, 2024

fixes #1072

This is similar to the set input in bake-action: docker/bake-action#97. We need to disable quotes detection for the outputs input by setting quote option to false: https://csv.js.org/parse/options/quote/

cc @alessfg

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit af5a7ed into docker:master Mar 7, 2024
52 checks passed
@crazy-max crazy-max deleted the build-cmd-debug branch March 7, 2024 18:55
montekki pushed a commit to matter-labs/zksync-withdrawal-finalizer that referenced this pull request Mar 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[docker/build-push-action](https://togithub.com/docker/build-push-action)
| action | minor | `v5.1.0` -> `v5.2.0` |

---

### Release Notes

<details>
<summary>docker/build-push-action (docker/build-push-action)</summary>

###
[`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0)

[Compare
Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0)

- Disable quotes detection for `outputs` input by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/build-push-action#1074
- Warn about ignored inputs by
[@&#8203;favonia](https://togithub.com/favonia) in
[docker/build-push-action#1019
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.14.0 to 0.18.0 in
[docker/build-push-action#1070
- Bump undici from 5.26.3 to 5.28.3 in
[docker/build-push-action#1057

**Full Changelog**:
docker/build-push-action@v5.1.0...v5.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to 4m-mazi/gh-test that referenced this pull request Mar 9, 2024
#700)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[docker/build-push-action](https://togithub.com/docker/build-push-action)
| action | minor | `v5.1.0` -> `v5.2.0` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/docker/build-push-action/badge)](https://securityscorecards.dev/viewer/?uri=github.com/docker/build-push-action)
|

---

### Release Notes

<details>
<summary>docker/build-push-action (docker/build-push-action)</summary>

###
[`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0)

[Compare
Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0)

- Disable quotes detection for `outputs` input by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/build-push-action#1074
- Warn about ignored inputs by
[@&#8203;favonia](https://togithub.com/favonia) in
[docker/build-push-action#1019
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.14.0 to 0.18.0 in
[docker/build-push-action#1070
- Bump undici from 5.26.3 to 5.28.3 in
[docker/build-push-action#1057

**Full Changelog**:
docker/build-push-action@v5.1.0...v5.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/4m-mazi/gh-test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use multiple names when using output type=image
2 participants