Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/build-push-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.0
Choose a base ref
...
head repository: docker/build-push-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.4.1
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 17, 2024

  1. Revert "set repository and ghtoken attributes for gha cache type" 

    This reverts commit 522345f.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
    @crazy-max
    crazy-max committed Jul 17, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    crazy-max CrazyMax
    GPG key ID: ADE44D8C9D44FBE4
    Verified
    Learn about vigilant mode
    Copy the full SHA
    d189d0e View commit details

  2. chore: update generated content 

    Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
    @crazy-max
    crazy-max committed Jul 17, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    2c95ebe View commit details

  3. Merge pull request #1183 from crazy-max/revert-gha-cache-to 

    revert "set repository and ghtoken attributes for gha cache type"
    @crazy-max
    crazy-max authored Jul 17, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    1ca370b View commit details
Showing with 3 additions and 24 deletions.
  1. +0 −21 __tests__/context.test.ts
  2. +1 −1 dist/index.js
  3. +1 −1 dist/index.js.map
  4. +1 −1 src/context.ts
21 changes: 0 additions & 21 deletions __tests__/context.test.ts
View file
Original file line number Diff line number Diff line change
@@ -799,27 +799,6 @@ ANOTHER_SECRET=ANOTHER_SECRET_ENV`]
'.'
]
],
[
34,
'0.14.1',
new Map<string, string>([
['context', '.'],
['load', 'false'],
['no-cache', 'false'],
['push', 'false'],
['pull', 'false'],
['cache-to', 'type=gha'],
['github-token', `abcd1234`],
]),
[
'build',
'--cache-to', 'type=gha,repository=docker/build-push-action,ghtoken=abcd1234',
'--iidfile', imageIDFilePath,
'--attest', `type=provenance,mode=min,inline-only=true,builder-id=https://github.com/docker/build-push-action/actions/runs/123456789/attempts/1`,
'--metadata-file', metadataJson,
'.'
]
],
])(
'[%d] given %p with %p as inputs, returns %p',
async (num: number, buildxVersion: string, inputs: Map<string, string>, expected: Array<string>) => {
2 changes: 1 addition & 1 deletion dist/index.js
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/context.ts
View file
Original file line number Diff line number Diff line change
@@ -139,7 +139,7 @@ async function getBuildArgs(inputs: Inputs, context: string, toolkit: Toolkit):
args.push('--cache-from', cacheFrom);
});
await Util.asyncForEach(inputs['cache-to'], async cacheTo => {
args.push('--cache-to', Build.resolveCacheToAttrs(cacheTo, inputs['github-token']));
args.push('--cache-to', cacheTo);
});
if (inputs['cgroup-parent']) {
args.push('--cgroup-parent', inputs['cgroup-parent']);