Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workdir option #76

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

tuler
Copy link
Contributor

@tuler tuler commented May 20, 2022

Adds a workdir option.

Fixes #65

@tuler tuler requested a review from crazy-max as a code owner May 20, 2022 06:30
@tuler tuler force-pushed the feature/working-directory branch 2 times, most recently from caa40ea to 73d2e19 Compare May 20, 2022 17:30
@tuler tuler force-pushed the feature/working-directory branch from 73d2e19 to 49296ad Compare June 10, 2022 00:22
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this new input while waiting for better support upstream in docker/buildx#1028.

See also my comment and ci failure.

PTAL @tonistiigi

action.yml Outdated Show resolved Hide resolved
@tuler tuler force-pushed the feature/working-directory branch from 49296ad to 78e325f Compare June 15, 2022 23:28
@tuler tuler force-pushed the feature/working-directory branch 2 times, most recently from 2d8e90e to ba83d0d Compare July 11, 2022 12:59
@crazy-max
Copy link
Member

Check CI: https://github.com/docker/bake-action/runs/7283346396?check_suite_focus=true#step:3:311

#29 [build-validate build-validate 1/1] RUN --mount=type=bind,target=.,rw <<EOT (set -e...)
#29 0.399 ERROR: Build result differs. Please build first with "docker buildx bake build"
#29 0.402  M dist/index.js
#29 0.402  M dist/index.js.map
#29 ERROR: executor failed running [/bin/sh -c set -e
git add -A
cp -rf /out/* .
if [ -n "$(git status --porcelain -- dist)" ]; then
  echo >&2 'ERROR: Build result differs. Please build first with "docker buildx bake build"'
  git status --porcelain -- dist
  exit 1
fi
]: exit code: 1

Signed-off-by: Danilo Tuler <tuler@pobox.com>
@tuler tuler force-pushed the feature/working-directory branch from ba83d0d to e917a42 Compare July 11, 2022 13:40
@tuler
Copy link
Contributor Author

tuler commented Jul 11, 2022

Check CI: https://github.com/docker/bake-action/runs/7283346396?check_suite_focus=true#step:3:311

Sorry, I was running yarn all instead.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, PTAL @tonistiigi

@crazy-max crazy-max changed the title Add working-directory option Add workdir option Jul 16, 2022
@crazy-max crazy-max requested a review from jedevc July 19, 2022 13:54
@crazy-max crazy-max merged commit 5cb4f0e into docker:master Jul 19, 2022
@tuler tuler deleted the feature/working-directory branch July 19, 2022 14:21
@tuler tuler restored the feature/working-directory branch July 19, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Ability to specify working-directory
4 participants