Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: update inspect command parsing #276

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 8, 2024

follow-up docker/buildx#2268, docker/buildx#1854
related to docker/buildx#2325 (comment)

Since Buildx 0.13, some keys have been renamed for buildx inspect command: https://github.com/docker/buildx/pull/2268/files#diff-201694404c6fd5e0d301670e34752d92835c43f21dc8e59e342b80a26848ec6fR87-R91

Also adds support for docker/buildx#1854 available since Buildx 0.11.

@crazy-max crazy-max marked this pull request as ready for review March 8, 2024 10:51
src/buildx/builder.ts Outdated Show resolved Hide resolved
src/buildx/builder.ts Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

ci issue is unrelated: https://github.com/docker/actions-toolkit/actions/runs/8248886389/job/22597083304?pr=276#step:5:111

  ==> Pouring python@3.12--3.12.2_1.ventura.bottle.tar.gz
  Error: The `brew link` step did not complete successfully
  The formula built, but is not symlinked into /usr/local
  Could not symlink bin/2to3
  Target /usr/local/bin/2to3
  already exists. You may want to remove it:
    rm '/usr/local/bin/2to3'

@tonistiigi tonistiigi merged commit e1fa386 into docker:main Mar 13, 2024
27 of 28 checks passed
@crazy-max crazy-max deleted the update-builder-inspect branch March 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants