Prevent HttpConsumer from hiding exceptions #1951
Conversation
|
FYI @alexmclarty - if you recall, we spotted this issue whilst pairing (on top of the original one we were debugging). |
| @@ -81,7 +81,7 @@ async def http_request(self, message): | |||
| await self.handle(b"".join(self.body)) | |||
| finally: | |||
| await self.disconnect() | |||
| raise StopConsumer() | |||
| raise StopConsumer() | |||
There was a problem hiding this comment.
what a difference an indentation level makes 😅
There was a problem hiding this comment.
💝 — This may be the root of one I've been meaning to sit down with for an age.
I shall take a proper look later one.
There was a problem hiding this comment.
So there may be failing HTTP consumers in production apps where the exceptions aren’t being logged.
Yes, that was the reported issue.
|
Thanks for fixing this well hidden bug! 👍 |
|
I'm planning new releases for the new year. This is on the roadmap for that. |
|
Hehe no worries, thanks for merging. |
Fixes #1950.
The issue didn’t only affect tests—exceptions were always swallowed by converting them into
StopConsumer(). So there may be failing HTTP consumers in production apps where the exceptions aren’t being logged.