Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce linting issues #468

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

adamantike
Copy link
Contributor

@adamantike adamantike commented Sep 16, 2022

These changes reduce the amount of linting issues that are silenced by the CI configuration.

  • Remove waffle/south_migrations/ folder from flake8 exclude list, as it no longer exists.
  • Migrate unused waffle/.flake file content to setup.cfg.
  • Fix simple linting issues that do not generate side effects.

Linting issues for the current master commit can be found at: https://github.com/django-waffle/django-waffle/actions/runs/3005138785/jobs/4825114427

These changes reduce the amount of linting issues that are silenced by
the CI configuration.

* Remove `waffle/south_migrations/` folder from `flake8` exclude list,
  as it no longer exists.
* Migrate unused `waffle/.flake` file content to `setup.cfg`.
* Fix simple linting issues that do not generate side effects.

Linting issues for the current `master` commit can be found at:
https://github.com/django-waffle/django-waffle/actions/runs/3005138785/jobs/4825114427
@adamantike adamantike force-pushed the fix/reduce-linting-issues branch from 6d3bcae to 2a8190c Compare September 16, 2022 18:56
@clintonb clintonb merged commit 1f512f0 into jazzband:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants