Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with lack of PosixPath support #1785

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Fix error with lack of PosixPath support #1785

merged 1 commit into from
Dec 25, 2022
+1 −1

Conversation

giff-h
Copy link
Contributor

@giff-h giff-h commented Dec 25, 2022

Current Django sets settings.BASE_DIR to a PosixPath object by default.

Python stdlib pkgutil and importlib do not yet support using PosixPath values, at least as of 3.10.9.

If the SHELL_PLUS_SUBCLASSES_IMPORT value is set under these conditions, attempting to launch shell_plus will result in an error:

AttributeError: 'PosixPath' object has no attribute 'startswith'

@giff-h
Fix error with lack of PosixPath support

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9749e9b
@trbs trbs merged commit b485615 into django-extensions:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giff-h @trbs