Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dark Mode Conflict in Pygments #2108

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

andoriyaprashant
Copy link
Member

Description

This PR resolves the dark mode conflict with Pygments syntax highlighting in Django Debug Toolbar. The issue was caused by the font color --djdt-font-color: #8393a7;, which made the text less readable.

Fixes #2096

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Sorry, something went wrong.

andoriyaprashant and others added 4 commits March 19, 2025 14:37

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
* main:
  [pre-commit.ci] pre-commit autoupdate (django-commons#2107)
  Reword a changelog entry
@matthiask
Copy link
Member

If you check the test run you'll find the following information:

 copying assets: done
writing output... [  9%] architecture
writing output... [ 18%] changes
changes.rst:7: : Spell check: Pygments: Fix Dark Mode Conflict in Pygments.
Writing /home/runner/work/django-debug-toolbar/django-debug-toolbar/docs/_build/spelling/changes.spelling
writing output... [ 27%] checks
writing output... [ 36%] commands
writing output... [ 45%] configuration

The spell checker doesn't like "Pygments" it seems. I have pushed an update and am waiting for the CI rerun.

@matthiask
Copy link
Member

@matthiask matthiask merged commit c557f24 into django-commons:main Mar 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode conflicts with pygments
2 participants