Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go and golang linter #4389

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

milosgajdos
Copy link
Member

@milosgajdos milosgajdos commented Jun 30, 2024

Bump Go, golangci-lint and alpine versions.

NOTE:

  • vet linter has been renamed to govet
  • there is no longer a run section in the config
  • skip-dirs has been renamed to exclude-dirs

@milosgajdos milosgajdos requested review from Jamstah and thaJeztah June 30, 2024 15:48
@github-actions github-actions bot added dependencies Pull requests that update a dependency file area/build labels Jun 30, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
go 1.21.8
go 1.22.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this on go1.21, unless the module can no longer work with go1.21 (which I doubt).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda wanted to bump it in prep for beta release 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right but the go mod now specifies the minimum required version; trying to use any package from the repo will not be rejected unless you're on go1.22.4

We can use go1.22 for building the binaries, but not sure if we need to enforce that version for using the module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm familiar, I think we had a similar discussion in #4347 RE: go toolchain version

Copy link
Collaborator

@davidspek davidspek Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you can leave this line as is and add a line with toolchain go1.22.4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah, I think @Jamstah and I discussed that but I cant remember what made us stick with the existing setup 🤷‍♂️ maybe he can chime in

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way I think this should be merged :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.21 will only be supported until ~August, so I feel like its probably worth bumping it.

Any project using this repo as a dependency should be keeping currency anyway. I don't think we break anyone until they update the dependency anyway.

Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is, or if the toolchain version is used instead. We should keep up with the Go versions.

@milosgajdos milosgajdos merged commit 60da193 into distribution:main Jul 9, 2024
16 checks passed
@milosgajdos milosgajdos deleted the bump-go-lint branch July 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants