add rdrw open disk mode #177
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't that dangerous? When the kernel opens a disk, it almost always opens it exclusive, does it not? |
|
Yes, but you can do it and for example cloud-int does this thing on start, using growpart to extend disk. I think - how you open disk is solely a user's responsibility. |
Which is the argument I have made over and over again with other projects, and here I am arguing against it. Hoisted on my own petard. Good point! |
deitch
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RDWR mode for
diskfs.Open(...), so partitions could be resized without exclusive write access. For example growpart uses sgdisk to resize partitions on running systems.