Detect block device size using platform-specific IOCTL on Mac & Linux #173
+79
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadutaf
force-pushed
the
feat-os-specific-block-get-size
branch
from
6d0974f to
9188c11
Compare
|
Let me know if you'd rather see 2 distinct PRs (one for the refactoring and 1 for the IOCTL) |
|
I like this, no need to split it. I have some questions, going to comment inline. |
deitch
reviewed
Mar 9, 2023
Darwin and Windows specific diskfs features already live in their own module. Linux support however remains in a catch-all "unix" modules that builds only for Linux in practice. This commit makes the Unix module only target Linux and introduces a new catch-all-other module to stub out block device specific functions. This paves the road for using platform-specific IOCTL to get the physical block device size and ultimately help with the Windows port of block device support. Signed-off-by: Jean-Tiare Le Bigot <jt@yadutaf.fr>
Currently, diskfs attempts to detect the size of a block device using a "seek" based approach. Unfortunately, while this looks generic, it does not work on Mac, at least not in a VM. Based on the previous commit, this commit adds a Mac and Linux implementation for getting the size of a Block device through IOCTL inspired by https://github.com/tytso/e2fsprogs/blob/master/lib/ext2fs/getsize.c This was manually tested using a Linux loopback device and in a Mac virtual machine. Closes diskfs#171 Signed-off-by: Jean-Tiare Le Bigot <jt@yadutaf.fr>
yadutaf
force-pushed
the
feat-os-specific-block-get-size
branch
from
9188c11 to
b03a5db
Compare
deitch
approved these changes
Mar 11, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, diskfs attempts to detect the size of a block device using a
"seek" based approach. Unfortunately, while this looks generic, it does
not work on Mac, at least not in a VM.
Based on the previous commit, this commit adds a Mac and Linux
implementation for getting the size of a Block device through IOCTL
inspired by https://github.com/tytso/e2fsprogs/blob/master/lib/ext2fs/getsize.c
This was manually tested using a Linux loopback device and in a Mac
virtual machine.