Skip to content

Commit fbd68ee

Browse files
committedNov 12, 2021
feat: node 17 support
1 parent 38199a3 commit fbd68ee

File tree

3 files changed

+457
-804
lines changed

3 files changed

+457
-804
lines changed
 

‎binding.gyp

+6
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@
3636
],
3737
"include_dirs": ["<!@(node -p \"require('node-addon-api').include\")"],
3838
"sources": ["src/node-opus.cc"],
39+
# gyp inside node v16 uses -rpath=$ORIGIN/ instead of -rpath=$ORIGIN/lib.target/
40+
# which fixes a longstanding descreptancy between platforms as documented at https://github.com/nodejs/node-gyp/issues/2233
41+
# This allows tests to pass for older, still buggy and inconsistent versions of node-gyp (and will be duplicative for npm >= 7 which bundles node-gyp >= v0.6.0)
42+
'ldflags': [
43+
"-Wl,-rpath=\$$ORIGIN/"
44+
],
3945
},
4046
],
4147
}

0 commit comments

Comments
 (0)