fix(Constants): Ordering and missing information #9500
Merged
+111
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Jiralite
changed the title
iCrawl
approved these changes
May 2, 2023
kyranet
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
After sorting the TypeScript constant alphabetically, I began to notice inconsistencies.
ApplicationCommandOptionTypesfrom the typingsModalComponentTypesin the typings, but it is not used anywhere or exported in JavaScriptApplicationRoleConnectionMetadataTypesto the typingsMessageTypeswas never documented (yes, this is very old)ThreadChannelTypesin the typings but was lacking documentationAlso sorted the JavaScript constant. It should be easier to detect these things when comparing them now.
Status and versioning classification: