fix: fixed TS 4.8 compatibility #8601
Merged
+3,125
−3,146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kyranet
approved these changes
Sep 6, 2022
vladfrangu
approved these changes
Sep 6, 2022
imranbarbhuiya
suggested changes
Sep 8, 2022
favna
commented
Sep 8, 2022
iCrawl
approved these changes
Sep 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Currently, users of DiscordJS v13 and TypeScript 4.8 require using
"skipLibCheck": truebecause the changed line raises type errors.At the same time, however, fixing the issue is unfeasible because it would also require
0.33.6of discord-api-types. I tried tracing the issue back to the source and the best I got went intoAPITextInputComponentand I can't go and change discord-api-types in node_modules.Other than that I also cleaned up some unused imports that were showing up.
Status and versioning classification: