Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SlashCommandBuilder): import Permissions correctly #7921

Merged
merged 2 commits into from
May 14, 2022

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Closes #7920

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@KhafraDev
Copy link
Contributor

Is it possible to remove the dom types from /rest completely?

../../../AppData/Roaming/npm/node_modules/typescript/lib/lib.dom.d.ts
  Library referenced via 'dom' from file 'node_modules/@discordjs/rest/dist/index.d.ts'

(using tsc --explainFiles)

@vladfrangu
Copy link
Member Author

Not related to this PR soooo 🤷
Check why they're used in rest and see if they can be removed

@SuperchupuDev
Copy link
Contributor

Would it be possible to support bigint in the method too? It works already and it's really useful because PermissionFlagsBits returns a BigInt

@vladfrangu
Copy link
Member Author

Woops. Nice catch - forgot I made the validator support bigints but not the actual method types

@iCrawl iCrawl added this to the builders v1 milestone May 14, 2022
@iCrawl iCrawl merged commit 7ce641d into main May 14, 2022
@iCrawl iCrawl deleted the fix/permission-type-for-slash-command-builders branch May 14, 2022 20:47
codetheweb added a commit to museofficial/muse that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bad typing for .setDefaultMemberPermissions()
7 participants