fix(StoreChannel): mark as deprecated #7072
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Dec 7, 2021
iCrawl
approved these changes
Dec 7, 2021
SpaceEEC
approved these changes
Dec 7, 2021
vladfrangu
approved these changes
Dec 7, 2021
mafineeek
approved these changes
Dec 7, 2021
|
Shouldn't the docs have these deprecation warnings as well as the code? |
|
It's not needed to add those deprecations into code since creating new store channels will result on an error (see linked issue). What we can do is deprecate the class (so we don't need to deprecate a lot of methods), although we probably should check for the docs that create store channels and mark them as deprecated. |
|
I would say add a warning block in the StoreChannel class and probably in the ChannelType typedef? That should be enough and we can let Discord do the other errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Marks
StoreChanneland all methods to create new ones as deprecated in the typings, as per Self-serve Game Selling Deprecation.Probably fixes #6610?. This is semver-patch, and Discord might re-add the possibility of creating new store channels (or a workaround to do so), so I'm not removing the support just yet. We can remove the class and anything related to it as soon as Discord removes them.
Status and versioning classification: