Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove data resolver exports #10701

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 12, 2025

These functions are private

Resolves DJS-60

Verified

This commit was signed with the committer’s verified signature.
almeidx Almeida
@almeidx almeidx requested a review from a team as a code owner January 12, 2025 22:00
Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 10:24am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 10:24am

@Jiralite
Copy link
Member

All of these seem to be @private/@internal, so removing the major label.

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Jan 12, 2025
@almeidx almeidx changed the title refactor!: remove data resolver exports refactor: remove data resolver exports Jan 12, 2025
almeidx and others added 2 commits January 13, 2025 10:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kodiakhq kodiakhq bot merged commit 28afb0c into main Jan 13, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the refactor/remove-data-resolver-export branch January 13, 2025 10:26
Jiralite pushed a commit that referenced this pull request Jan 13, 2025

Partially verified

This commit is signed with the committer’s verified signature.
Jiralite’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
refactor!: remove data resolver exports

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants