Skip to content

Commit 941642a

Browse files
authoredDec 3, 2023
fix: replace internal calls to Emoji#url (#10025)
1 parent 54453b0 commit 941642a

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed
 

‎packages/discord.js/src/managers/RoleManager.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ class RoleManager extends CachedManager {
139139
color &&= resolveColor(color);
140140
if (permissions !== undefined) permissions = new PermissionsBitField(permissions);
141141
if (icon) {
142-
const guildEmojiURL = this.guild.emojis.resolve(icon)?.url;
142+
const guildEmojiURL = this.guild.emojis.resolve(icon)?.imageURL();
143143
icon = guildEmojiURL ? await DataResolver.resolveImage(guildEmojiURL) : await DataResolver.resolveImage(icon);
144144
if (typeof icon !== 'string') icon = undefined;
145145
}
@@ -191,7 +191,7 @@ class RoleManager extends CachedManager {
191191

192192
let icon = options.icon;
193193
if (icon) {
194-
const guildEmojiURL = this.guild.emojis.resolve(icon)?.url;
194+
const guildEmojiURL = this.guild.emojis.resolve(icon)?.imageURL();
195195
icon = guildEmojiURL ? await DataResolver.resolveImage(guildEmojiURL) : await DataResolver.resolveImage(icon);
196196
if (typeof icon !== 'string') icon = undefined;
197197
}

‎packages/discord.js/src/structures/Emoji.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,13 @@ class Emoji extends Base {
102102
}
103103

104104
toJSON() {
105-
return super.toJSON({
105+
const json = super.toJSON({
106106
guild: 'guildId',
107107
createdTimestamp: true,
108-
url: true,
109108
identifier: true,
110109
});
110+
json.imageURL = this.imageURL();
111+
return json;
111112
}
112113
}
113114

0 commit comments

Comments
 (0)
Please sign in to comment.