Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print raw diff when there is error during jsonDiff for -json flag #81

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dineshba
Copy link
Owner

It is a short-term fix to show raw string and show warning in stderr where is there json diff error for -json flag #26.

Long term fix: Need to investigate on this and parse it properly and show the diff

Issue details:

  • I am able to reproduce this issue only when the metadata field in the helm release is removed. For other changes it is able to easily handle. In the below file, if we remove metadata from either before or change resource changes, it is failing and printing empty. So, as short term, during this error showing the raw string.

tfplan.json

Verified

This commit was signed with the committer’s verified signature.
@dineshba dineshba merged commit eac0f29 into main Oct 24, 2024
1 check passed
@dineshba dineshba deleted the json-parse-error branch October 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant