Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print change summary as json #22

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

cgroschupp
Copy link
Contributor

Maybe this is the beginning of this TODO

@dineshba
Copy link
Owner

Hi @cgroschupp Thanks for the PR

Sorry, I was not very descriptive in the TODO list. What I meant there is We have to show the current terraform state summary. Like what are the resources already created (whatever available in terraform state). And show them in formats like tree/drawable-tree/table

User has to run terraform plan before running tf-summarize. Plan itself will summary count in the last line, which is same as json-sum. Could you please help me in understanding the usecase of the json-sum output.

@dineshba dineshba added the question Further information is requested label Jan 5, 2023
@dineshba
Copy link
Owner

@cgroschupp Please share your thoughts

@Terraformadillo
Copy link

Is this PR ever planning to get merged?

Verified

This commit was signed with the committer’s verified signature.
@cgroschupp
Copy link
Contributor Author

@dineshba My use case behind the json-sum was to get the change result in structured form (json) and extract information with jq. And my pipeline reacts differently to this result.

@Terraformadillo yes, ready to merge

dineshba
dineshba previously approved these changes Oct 17, 2024
@dineshba
Copy link
Owner

Could you help in test fixing ? @cgroschupp

Looks we added new tests which is failing now... we might have to update the error message... I can also look into it if you are packed

@cgroschupp
Copy link
Contributor Author

Now the tests should be OK.

@dineshba dineshba merged commit 4e3f1ce into dineshba:main Oct 19, 2024
1 check passed
@dineshba
Copy link
Owner

Thanks for the PR... Merged and release it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants