Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish GradleExtension tests #1908

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Nov 26, 2023

Changed:

  • Remove redundant tests in GroovyGradleExtensionTest, and let it extend GroovyExtensionTest.
  • Remove redundant tests in KotlinGradleExtensionTest, and let it extend KotlinExtensionTest.
  • Bump Kotlin plugins for Java 21 tests in the future.

Follow up:

We can't use the latest version, due to the Gradle matrix limit in tests.
" id 'org.jetbrains.kotlin.jvm' version '1.5.31'",
" id 'org.jetbrains.kotlin.jvm' version '1.6.21'",
Copy link
Contributor Author

@Goooler Goooler Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump this for #1907, can't use newer Kotlin versions due to the limit of Gradle matrix.

@nedtwigg nedtwigg merged commit c4f8a88 into diffplug:main Nov 27, 2023
11 checks passed
@Goooler Goooler deleted the bump-kt-plugin-in-tests branch November 27, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants