IllegalArgumentException: Unknown os.arch aarch64

[rawlingsj]

The Jenkins project recently enabled spotless-maven-plugin for Jenkinsfiles see jenkinsci/jenkins#7834. As a result we have started seeing errors when building on aarch64, s390x and ppc64le

Caused by: java.lang.IllegalArgumentException: Unknown os.arch s390x'.
    at com.diffplug.common.swt.os.OS.calculateNative (OS.java:147)
    at com.diffplug.common.swt.os.OS.detectPlatform (OS.java:113)
    at com.diffplug.common.swt.os.OS.detectPlatform (OS.java:120)

After a quick look could it be this code

durian-swt/durian-swt.os/src/main/java/com/diffplug/common/swt/os/OS.java

Lines 138 to 148 in 385d94a

	String os_arch = systemProperty.apply("os.arch");
	switch (os_arch) {
	case "i386":
	case "x86":
	return LINUX_x86;
	case "x86_64":
	case "amd64":
	return LINUX_x64;
	default:
	throw new IllegalArgumentException("Unknown os.arch " + os_arch + "'.");
	}

that needs needs to handle extra architectures?

[nedtwigg]

Can you make the stacktrace deeper? To show where Spotless is using this library?

I ask because durian-swt is targeted towards SWT, which no longer produces binaries for s390x and ppc64le. We could fix the aarch64 issue easily by just updating to the latest version of durian-swt, which has supported aarch64 for a while.

durian-swt/durian-swt.os/src/main/java/com/diffplug/common/swt/os/Arch.java

Lines 19 to 20 in 385d94a

	public enum Arch {
	x86, x64, arm64;

Maybe we should add an Arch.UNKNOWN, for unknown Architectures. As long as the user never needs platform-specific artifacts like SWT UI libraries (such as for Spotless code formatter), the unknown architecture would just pass along...

[rawlingsj]

Can you make the stacktrace deeper?

sure thing...

jenkins_2.402.log

[nedtwigg]

FYI, the fix above has been incorporated into spotless-plugin-gradle 6.19.0 and spotless-plugin-maven 2.37.0.