Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensuring that dashboards dir exists in all tests #3278

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

NikolaMilosa
Copy link
Contributor

This PR ensures that both k8s and farm based testnets have a directory for grafana dashboards (even if they are empty). This is to prevent having log lines like the following:

2024-12-20 03:22:31.400 INFO[uvms_logs_stream:StdOut] [uvm=prometheus] JournalRecord {message: "logger=provisioning.dashboard type=file name=provisioned-grafana-dashboards t=2024-12-20T03:22:30.89689519Z level=error msg="Cannot read directory" error="stat /config/grafana/dashboards: no such file or directory"", system_unit: "grafana.service", comm: "grafana"}

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@NikolaMilosa NikolaMilosa requested a review from a team as a code owner December 20, 2024 10:29
@github-actions github-actions bot added the fix label Dec 20, 2024
@NikolaMilosa NikolaMilosa added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit 50eea65 Dec 23, 2024
25 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-ensuring-dashboards-dir branch December 23, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants