Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password grant flow doesn't log errors from Login method #1813

Closed
tomqwpl opened this issue Oct 4, 2020 · 0 comments · Fixed by #2454
Closed

Password grant flow doesn't log errors from Login method #1813

tomqwpl opened this issue Oct 4, 2020 · 0 comments · Fixed by #2454

Comments

@tomqwpl
Copy link
Contributor

tomqwpl commented Oct 4, 2020

Standard flow:

	identity, ok, err := passwordConnector.Login(r.Context(), scopes, username, password)
	if err != nil {
		s.logger.Errorf("Failed to login user: %v", err)

Password flow:

identity, ok, err := passwordConnector.Login(r.Context(), parseScopes(scopes), username, password)
if err != nil {
	s.tokenErrHelper(w, errInvalidRequest, "Could not login user", http.StatusBadRequest)
al45tair pushed a commit to WorldProgrammingLtd/dex that referenced this issue Oct 7, 2020
Issues: dexidp#1813
Signed-off-by: Alastair Houghton <alastair@alastairs-place.net>
@nabokihms nabokihms linked a pull request Mar 31, 2022 that will close this issue
elffjs pushed a commit to DIMO-Network/dex that referenced this issue Jun 27, 2022
Issues: dexidp#1813
Signed-off-by: Alastair Houghton <alastair@alastairs-place.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant