Remove check for deprectated functions toUpperCase and toLowerCase #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6548 +/- ##
=========================================
Coverage 85.10% 85.11%
+ Complexity 4083 4079 -4
=========================================
Files 570 570
Lines 13376 13363 -13
Branches 2406 2401 -5
=========================================
- Hits 11384 11374 -10
Misses 792 792
+ Partials 1200 1197 -3
☔ View full report in Codecov by Sentry. |
schalkms
approved these changes
Oct 18, 2023
cortinico
approved these changes
Oct 21, 2023
| @@ -33,17 +30,13 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe | |||
| * "Timestamp: %d".format(System.currentTimeMillis()) | |||
| * | |||
| * val str: String = getString() | |||
| @@ -33,17 +30,13 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe | |||
| * "Timestamp: %d".format(System.currentTimeMillis()) | |||
| * | |||
| * val str: String = getString() | |||
| * str.toUpperCase() | |||
| * str.toLowerCase() | |||
| * </noncompliant> | |||
| * | |||
| * <compliant> | |||
| * String.format(Locale.US, "Timestamp: %d", System.currentTimeMillis()) | |||
| * "Timestamp: %d".format(Locale.US, System.currentTimeMillis()) | |||
| * | |||
| * val str: String = getString() | |||
marschwar
approved these changes
Oct 31, 2023
toUpperCase and toLowerCase are deprecated, the ImplicitDefaultLocale should not check usage for them anymore Closes detekt#6343
BraisGabin
added
the
pick request
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
…etekt#6548) toUpperCase and toLowerCase are deprecated, the ImplicitDefaultLocale should not check usage for them anymore Closes detekt#6343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toUpperCaseandtoLowerCaseare deprecated, theImplicitDefaultLocaleshould not check usage for them anymoreCloses #6343